[#380] Update StoryFactory v2 address and ABI#381
Conversation
Update mainnet address to 0x27B4FCf333f29a3865b3B76ea00C955D7b64BD0F, add hasSunset, updateCurve, owner, CurveUpdated to ABI, fix createStoryline stateMutability to payable, and update SDK deployment block. Fixes #380 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Reviewed diff against issue #380 acceptance criteria:
✅ Constants updated — mainnet address 0x27B4...BD0F in both web app and SDK
✅ Deployment block updated in SDK (43_606_398)
✅ ABI additions — hasSunset, updateCurve, owner, CurveUpdated all present with correct signatures
✅ createStoryline stateMutability corrected to payable (matches v2 contract)
✅ SDK mirrors web app ABI/constants changes
✅ Typecheck and lint pass (per PR)
On sunset references: T3's assessment is correct — all remaining sunset references (~13 files) are Supabase DB queries, UI conditionals reading from DB, type definitions, and docs. None are direct contract reads. The DB sunset column is populated by the indexer and is still valid. Updating those references would be an indexer/schema task, not a web app contract update.
Clean, focused diff. No issues found.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The ABI and address updates look consistent, and CI is passing, but the PR does not fully implement the issue scope for the web app constants.
Findings
- [medium] The web app deployment block update is missing.
- File:
lib/contracts/constants.ts:27 - Suggestion: add or update the mainnet deployment-block constant in the web app alongside the new StoryFactory address so the app matches issue #380 and stays in sync with the SDK update at
packages/sdk/src/constants.ts:29.
- File:
Decision
Requesting changes because issue #380 explicitly requires updating lib/contracts/constants.ts with both the new mainnet address and deployment block, but this PR only changes the address on the web-app side.
Adds mainnet deployment block (43_606_398) to lib/contracts/constants.ts to match the SDK, per reviewer feedback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up update adds the missing web-app deployment block, and the ABI/address changes remain consistent across the app and SDK.
Findings
- None.
Decision
Approving because the PR now matches issue #380 scope and the lint-and-typecheck check passed on the latest push.
2 participants
Summary
0x27B4FCf333f29a3865b3B76ea00C955D7b64BD0FhasSunset,updateCurve,ownerfunctions andCurveUpdatedevent to ABIcreateStorylinestateMutability fromnonpayabletopayablesunsetreferences are all Supabase DB queries (not contract reads) — no changes neededAcceptance
npm run typecheckpassesnpm run lintpassesFixes #380
🤖 Generated with Claude Code